Add batch cancel, enriched events, and partial fill improvements#4
Open
z0r0z wants to merge 2 commits into
Open
Add batch cancel, enriched events, and partial fill improvements#4z0r0z wants to merge 2 commits into
z0r0z wants to merge 2 commits into
Conversation
…events - Zero out amountA/amountB on full fill for clean state and storage refunds - Add early active checks in fillOrderWithEth and fillOrderUnwrap for correct error messages - Extract _emitFillEvent helper to eliminate duplicated emit logic across 3 fill paths - Add cancelOrders and cancelOrdersUnwrap for batch cancel support - Extract _cancelOrder and _cancelOrderUnwrap internals for DRY batch/single paths - Enrich OrderFilled and OrderPartiallyFilled events with maker, tokenA, tokenB for indexer parity - Enrich OrderCanceled event with maker, tokenA, amountA - Pin Solidity pragma to ^0.8.34 (avoids transient storage clearing bug in <=0.8.33) - Bump optimizer runs to 9,999,999 for maximum runtime gas efficiency - Add .claude-skills/ to gitignore - Add 22 new tests covering batch cancel, zeroed state, early active checks, and enriched events Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@z0r0z is attempting to deploy a commit to the ETHCF Team on Vercel. A member of the Team first needs to authorize it. |
z0r0z
changed the title
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancelOrdersandcancelOrdersUnwrap_emitFillEvent,_cancelOrder,_cancelOrderUnwrap^0.8.34, optimizer runs 9,999,999Test plan
🤖 Generated with Claude Code